Skip to content

Fix GitHub Actions workflow following #247#249

Merged
brettcannon merged 5 commits into
pypa:masterfrom
mayeut:fix-gh-workflow
Dec 17, 2019
Merged

Fix GitHub Actions workflow following #247#249
brettcannon merged 5 commits into
pypa:masterfrom
mayeut:fix-gh-workflow

Conversation

@mayeut
Copy link
Copy Markdown
Member

@mayeut mayeut commented Dec 17, 2019

Mitigate #246

Fix GitHub Actions workflow following #247, also triggers GH Actions workflow on workflow change (7e60ba4)
Do not cancel running jobs on first failure (5014760)
Also fix PyPy test failure following PyPy upgrade on GitHub Actions virtual environments (ca764a5)
Also fix a Windows test issue (failing silently, c.f. ebd0f93 & 076ae9f)

@mayeut mayeut force-pushed the fix-gh-workflow branch 2 times, most recently from f966f91 to 56cd7b0 Compare December 17, 2019 20:50
@mayeut
Copy link
Copy Markdown
Member Author

mayeut commented Dec 17, 2019

@mayeut
Copy link
Copy Markdown
Member Author

mayeut commented Dec 17, 2019

Please note that failing tests on windows are not marked as failed by CI: https://github.com/pypa/packaging/runs/329740554

@mayeut
Copy link
Copy Markdown
Member Author

mayeut commented Dec 17, 2019

@brettcannon, PR is ready for review, waiting for macOS fixes on GitHub Actions.

@brettcannon brettcannon merged commit 2a87d1c into pypa:master Dec 17, 2019
@mayeut mayeut deleted the fix-gh-workflow branch December 18, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants