fix: EncodingWarning#512
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 72.73% 70.09% -2.65%
==========================================
Files 13 13
Lines 1060 1060
==========================================
- Hits 771 743 -28
- Misses 289 317 +28
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
FYI, I'm fine if you select "update by rebase" from the dropdown on the PR for my PRs, you don't need to merge, I don't mind the rebase. If a PR stays open long enough, the merges eventually make it a mess (I spent hours trying to pull the actual changes from pypa/build#361 but couldn't untangle it). Depends on the contributor, but I don't mind resetting. |
Noted. Personally I prefer merges to the PR branch while I'm working on one. |
|
Looks like the merge from |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
c099007 to
c8c99a1
Compare
|
Thanks! |
For reference, this is PEP 597, in Python 3.10+, and happens when PYTHONWARNDEFAULTENCODING is set.
This cherry-picks @methane's #504, but adds two new commits; one that adds testing for this (using my favorite pytest settings), and one that fixes two more cases of missing encodings discovered by adding those tests.