tests: use modern tmp_path instead of py.path based tmpdir#513
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Contributor
|
I actually made this change in the |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 68.35% 68.35%
=======================================
Files 12 12
Lines 929 929
=======================================
Hits 635 635
Misses 294 294 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses pathlib-based tmp_path instead of py.path based tmpdir fixtures. Should be fine for pytest 6+, I think. Came up in the context of #512, though you can't quite remove the
_pytestwarning suppression, as there's one remaining thing in pytest that is missing an encoding.