Fix call to pytest.mark.usefixtures without arguments#746
Fix call to pytest.mark.usefixtures without arguments#746youtux merged 2 commits intopytest-dev:masterfrom
Conversation
This will raise a warning in an upcoming change in pytest
|
I think we need to either introduce a sort of "ScenarioFunction" protocol for mypy to be happy and expect scenario, or some short term ignoring of the mypy error, unless I am missing something, @youtux ? |
|
It's not quite clear to me how this change leads to mypy suddenly seeing the type of def (request: _pytest.fixtures.FixtureRequest, _pytest_bdd_example: builtins.dict[builtins.str, builtins.str]) -> AnyGiven the decorator is typed, this should already have been the case before I believe? As this isn't really related to this PR and we do a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 95.95% 95.95%
=======================================
Files 55 55
Lines 2199 2200 +1
Branches 242 242
=======================================
+ Hits 2110 2111 +1
Misses 54 54
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Actually I wanted to fix that in a different way. I started the work in #658, but never got to finish it... |
Ah, yes! I remember this now! |
This will raise a warning in an upcoming change in pytest.