Fix pytest.mark.usefixtures() without arguments silently erroring

[daria-shaw]

Follow up to #12439.

Closes #12426
Closes #12439

[nicoddemus]

Thanks @daara-s for picking this up, and also thanks to @JiajunXu2 for the initial PR. 👍

[nicoddemus]

Hmm this is breaking the plugins check, more specifically pytest-bdd:

ERROR bdd_wallet.py - pytest.PytestWarning: usefixtures() without arguments has no effect

Seems like pytest-bdd does this:

        # We need to tell pytest that the original function requires its fixtures,
        # otherwise indirect fixtures would not work.
        @pytest.mark.usefixtures(*func_args)

Perhaps we might need to update pytest-bdd to not apply the mark if there are no fixture in order to avoid this warning.

@The-Compiler what do you think?

EDIT: in 1b6b836 I ignored the warning to get the tests to pass.

[The-Compiler]

Oh, that's unfortunate... Like you say I suppose pytest-bdd could do the decorating manually and conditionally, in the same way as just below the linked code snippet:

        example_parametrizations = collect_example_parametrizations(templated_scenario)
        if example_parametrizations is not None:
            # Parametrize the scenario outlines
            scenario_wrapper = pytest.mark.parametrize(
                "_pytest_bdd_example",
                example_parametrizations,
            )(scenario_wrapper)

cc @youtux @jsa34 as a heads-up.

[daria-shaw]

@The-Compiler this what you mean?

[daria-shaw]

Got ahead of myself with the revert. Still need to bump the plugin pin.

@youtux what's the release cadence for pytest-bdd?

[youtux]

We don't really have a schedule, just whenever we think it's needed.

[nicoddemus]

Thanks @daara-s and @JiajunXu2 for the work here! 👍

[JiajunXu2]

Sorry for stepping away from the pr, I've been a bit busy lately. Thank you @daara-s for finishing it, and everyone for the support!