Remove request_ctx Fixture#168
Merged
nicoddemus merged 4 commits intopytest-dev:masterfrom Oct 23, 2023
Merged
Conversation
jlpoveda-jt
approved these changes
Oct 3, 2023
somethingnew2-0
approved these changes
Oct 5, 2023
|
Is there anything stopping this from being merged now and a release being made? |
|
I'm interested in a new release with that too :) |
Merged
Member
|
I'm improving/fixing CI in #169, after that gets merged I think we can merge this one as well. |
Member
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
My understanding is that the internal api used there is intentionally made gone
Is there another way we can safely enter the request context?
Member
|
Nm, I wasn't in the full picture |
foarsitter
approved these changes
Oct 10, 2023
medwards1771
approved these changes
Oct 16, 2023
Member
|
Thanks a lot @threeal and sorry for the delay. I will prepare a new release shortly. |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removed the
request_ctxfixture since it has been marked deprecated for a long time and currently it is not supported on the Flask v3.0.0.For a side note, inlining the import won't work since it could still break the test if using Flask v3.0.0.
pytest-flaskimport of_request_ctx_stack#167.Checklist:
docs/CHANGELOG.rst, summarizing the change and linking to the issue.pre-commithooks and fix any issues.pytestand make sure no tests failed.