Modernize CI workflow#169
Merged
nicoddemus merged 3 commits intopytest-dev:masterfrom Oct 23, 2023
Merged
Conversation
nicoddemus
force-pushed
the
modernize-ci
branch
2 times, most recently
from
7f6038f to
f0be165
Compare
This PR uses the same workflow we have been using in other projects under pytest-dev: * Separete `test` and `deploy` workflows. * `test`: build package once and test it in the supported environments, as opposed to generate one package for each environment. * `deploy`: a manually triggered action, which once successful will tag the repository and create a GH release.
nicoddemus
force-pushed
the
modernize-ci
branch
from
f0be165 to
9d7afbf
Compare
nicoddemus
commented
Oct 9, 2023
nicoddemus
force-pushed
the
modernize-ci
branch
3 times, most recently
from
1ce2d78 to
41bc596
Compare
This allows us to confidently test the package created by a separate job on CI.
nicoddemus
force-pushed
the
modernize-ci
branch
from
41bc596 to
e0e3c2c
Compare
Unfortunately those tests are skipped on Windows, which skews code coverage stats.
foarsitter
approved these changes
Oct 10, 2023
foarsitter
left a comment
foarsitter
left a comment
There was a problem hiding this comment.
Didn't test locally but looks good to me.
Member
Author
|
Thanks @foarsitter. @northernSage gentle ping -- please let me know in case you are swamped and won't have the time to handle the recent PRs, in which case I can take care of them. |
Member
Author
|
Going ahead and merge this to get a new release out. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the same workflow we have been using in other projects under pytest-dev:
testanddeployworkflows.test: build package once and test it in the supported environments, as opposed to generate one package for each environment.deploy: a manually triggered action, which once successful will tag the repository and create a GH release.srclayout: this makes it possible to create the package and test it in different jobs on CI, and ensures we are testing the actual package.Fixes #166