Conversation
blueyed
commented
Oct 14, 2018
blueyed
commented
- CI: run specialized factors in a single job
- AppVeyor: fast_finish
Given the setup time for jobs, it makes sense to run *-pexpect,*-trial,*-numpy in a single build job.
This runs py27, py37 and linting first - simulating the baseline stage used on Travis.
| # note: please use "tox --listenvs" to populate the build matrix below | ||
| # please remove the linting env in all cases | ||
| - TOXENV=py27-pexpect | ||
| # Specialized factors for py27. |
There was a problem hiding this comment.
What was the reasoning here for plumping pexpect, trial, and numpy together, while keeping xdist and pluggymaster separate? I'm curious.
There was a problem hiding this comment.
xdist and pluggymaster run the whole test suite, while the others only run parts of it.
Initially I've thought to just install pexpect on CI by default, but then it would slow more jobs down.
Re pexpect I think it could even use a marker or similar to really run only pexpect tests maybe even.
There was a problem hiding this comment.
xdist and pluggymaster run the whole test suite, while the others only run parts of it.
I see, makes sense. Please add a comment so the rationale is explicit.
Re pexpect I think it could even use a marker or similar to really run only pexpect tests maybe even.
I suspect it won't really change the overall time much (if at all).
There was a problem hiding this comment.
Please add a comment so the rationale is explicit.
"Specialized factors for py27." was meant to be for that. But maybe put it on the same line then? Better wording?
There was a problem hiding this comment.
"Specialized tests for py27"? Not sure, the wording might be fine and it was my fault for not understanding it right away hehehe
There was a problem hiding this comment.
Let's maybe wait for another pair of eyes then.
|
Let's go ahead, no sense in keeping this waiting in account of a single comment. 👍 |
3 participants
