Skip to content

Faster CI #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicoddemus merged 2 commits into from
Oct 14, 2018
Merged

Faster CI #4140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d0667f
CI: run specialized factors in a single job
blueyed Oct 14, 2018
7ded937
AppVeyor: use fast_finish
blueyed Oct 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,15 @@ install:
- pip install --upgrade --pre tox
env:
matrix:
# note: please use "tox --listenvs" to populate the build matrix below
# please remove the linting env in all cases
- TOXENV=py27-pexpect
# Specialized factors for py27.
Copy link
Member

@nicoddemus nicoddemus Oct 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reasoning here for plumping pexpect, trial, and numpy together, while keeping xdist and pluggymaster separate? I'm curious.

Copy link
Contributor Author

@blueyed blueyed Oct 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xdist and pluggymaster run the whole test suite, while the others only run parts of it.

Initially I've thought to just install pexpect on CI by default, but then it would slow more jobs down.

Re pexpect I think it could even use a marker or similar to really run only pexpect tests maybe even.

Copy link
Member

@nicoddemus nicoddemus Oct 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xdist and pluggymaster run the whole test suite, while the others only run parts of it.

I see, makes sense. Please add a comment so the rationale is explicit.

Re pexpect I think it could even use a marker or similar to really run only pexpect tests maybe even.

I suspect it won't really change the overall time much (if at all).

Copy link
Contributor Author

@blueyed blueyed Oct 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment so the rationale is explicit.

"Specialized factors for py27." was meant to be for that. But maybe put it on the same line then? Better wording?

Copy link
Member

@nicoddemus nicoddemus Oct 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Specialized tests for py27"? Not sure, the wording might be fine and it was my fault for not understanding it right away hehehe

Copy link
Contributor Author

@blueyed blueyed Oct 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe wait for another pair of eyes then.

- TOXENV=py27-pexpect,py27-trial,py27-numpy
- TOXENV=py27-nobyte
- TOXENV=py27-xdist
- TOXENV=py27-trial
- TOXENV=py27-numpy
- TOXENV=py27-pluggymaster PYTEST_NO_COVERAGE=1
- TOXENV=py36-pexpect
# Specialized factors for py36.
- TOXENV=py36-pexpect,py36-trial,py36-numpy
- TOXENV=py36-xdist
- TOXENV=py36-trial
- TOXENV=py36-numpy
- TOXENV=py36-pluggymaster PYTEST_NO_COVERAGE=1
- TOXENV=py27-nobyte

jobs:
include:
Expand Down
26 changes: 14 additions & 12 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,29 @@
environment:
matrix:
- TOXENV: "linting,docs,doctesting"
PYTEST_NO_COVERAGE: "1"
- TOXENV: "py27"
- TOXENV: "py34"
- TOXENV: "py35"
- TOXENV: "py36"
- TOXENV: "py37"
PYTEST_NO_COVERAGE: "1"
- TOXENV: "linting,docs,doctesting"
- TOXENV: "py36"
- TOXENV: "py35"
- TOXENV: "py34"
- TOXENV: "pypy"
PYTEST_NO_COVERAGE: "1"
- TOXENV: "py27-xdist"
- TOXENV: "py27-trial"
- TOXENV: "py27-numpy"
# Specialized factors for py27.
- TOXENV: "py27-trial,py27-numpy,py27-nobyte"
- TOXENV: "py27-pluggymaster"
PYTEST_NO_COVERAGE: "1"
- TOXENV: "py36-xdist"
- TOXENV: "py36-trial"
- TOXENV: "py36-numpy"
- TOXENV: "py27-xdist"
# Specialized factors for py36.
- TOXENV: "py36-trial,py36-numpy"
- TOXENV: "py36-pluggymaster"
PYTEST_NO_COVERAGE: "1"
- TOXENV: "py27-nobyte"
- TOXENV: "py36-freeze"
PYTEST_NO_COVERAGE: "1"
- TOXENV: "py36-xdist"

matrix:
fast_finish: true

install:
- echo Installed Pythons
Expand Down