Skip to content

Issue a warning when a fixture named 'request' is collected#4209

Merged
crazymerlyn merged 1 commit intopytest-dev:featuresfrom
nicoddemus:fixture-named-request
Oct 21, 2018
Merged

Issue a warning when a fixture named 'request' is collected#4209
crazymerlyn merged 1 commit intopytest-dev:featuresfrom
nicoddemus:fixture-named-request

Conversation

@nicoddemus
Copy link
Member

Fix #611

@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #4209 into features will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           features   #4209      +/-   ##
===========================================
+ Coverage      95.8%   95.8%   +<.01%     
===========================================
  Files           109     109              
  Lines         24231   24240       +9     
  Branches       2389    2390       +1     
===========================================
+ Hits          23215   23224       +9     
  Misses          721     721              
  Partials        295     295
Flag Coverage Δ
#docs 28.49% <36.36%> (-0.01%) ⬇️
#doctesting 28.49% <36.36%> (-0.01%) ⬇️
#linting 28.49% <36.36%> (-0.01%) ⬇️
#linux 95.58% <100%> (ø) ⬆️
#nobyte 91.87% <100%> (ø) ⬆️
#numpy 92.91% <100%> (ø) ⬆️
#pexpect 41.31% <36.36%> (-0.01%) ⬇️
#py27 93.94% <100%> (ø) ⬆️
#py34 92.27% <100%> (+0.03%) ⬆️
#py35 92.28% <100%> (+0.03%) ⬆️
#py36 93.94% <100%> (ø) ⬆️
#py37 92.31% <100%> (+0.03%) ⬆️
#trial 92.91% <100%> (ø) ⬆️
#windows 94.04% <100%> (ø) ⬆️
#xdist 93.77% <100%> (ø) ⬆️
Impacted Files Coverage Δ
testing/deprecated_test.py 100% <100%> (ø) ⬆️
src/_pytest/fixtures.py 97.31% <100%> (+0.01%) ⬆️
src/_pytest/deprecated.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b432f12...7bb51b8. Read the comment docs.

@crazymerlyn crazymerlyn merged commit f30911d into pytest-dev:features Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants