Conversation
Codecov Report
@@ Coverage Diff @@
## master #4217 +/- ##
==========================================
- Coverage 95.81% 94.73% -1.08%
==========================================
Files 109 109
Lines 24295 24378 +83
Branches 2395 2399 +4
==========================================
- Hits 23278 23095 -183
- Misses 721 988 +267
+ Partials 296 295 -1
Continue to review full report at Codecov.
|
| - brew update | ||
| # update gcc first because it was breaking the py37 update as of 2018-10-23; | ||
| # might not be necessary in the future | ||
| - rm '/usr/local/include/c++' |
There was a problem hiding this comment.
Following what brew recommends in its error message:
Could not symlink include/c++
Target /usr/local/include/c++
already exists. You may want to remove it:
rm '/usr/local/include/c++'
@jaraco does this seem correct to you? Any other suggestion?
There was a problem hiding this comment.
Oh sorry, I'm mis-remembering, who contributed the macos builds was not @jaraco.
@jirikuncar what do you think?
There was a problem hiding this comment.
Is this symlink in the Travis image already? You might want to ls -l it in the beginning.
There was a problem hiding this comment.
This happens when also upgrading numpy (https://travis-ci.org/pytest-dev/pytest/jobs/444989259#L933), which maybe can be avoided with some option to "brew upgrade python" to not upgrade dependents? (should be faster then, too)
|
Pushed a commit that uses Edit: reverted (d04965b), still failed in the same way (upgrading numpy => gcc). |
d04965b to
5db0a82
Compare
|
Thanks for chipping in @blueyed. 👍 Let's see what @jirikuncar has to say. |
This has been failing as of 2018-10-23 while installing gcc with this message: ==> Installing numpy dependency: gcc ==> Downloading https://homebrew.bintray.com/bottles/gcc-8.2.0.high_sierra.bottl ######################################################################## 100.0% ==> Pouring gcc-8.2.0.high_sierra.bottle.1.tar.gz Error: The `brew link` step did not complete successfully The formula built, but is not symlinked into /usr/local Could not symlink include/c++ Target /usr/local/include/c++ already exists. You may want to remove it: rm '/usr/local/include/c++' To force the link and overwrite all conflicting files: brew link --overwrite gcc To list all files that would be deleted: brew link --overwrite --dry-run gcc Possible conflicting files are: /usr/local/include/c++ -> /usr/local/Caskroom/oclint/0.13.1,17.4.0/oclint-0.13.1/include/c++
5db0a82 to
28dbffd
Compare
|
Well let's get this merged, as having every PR failing because of this is distracting. |
|
(We will need at least 1 approval before we can merge this btw) |
This has been failing as of 2018-10-23 while installing gcc with
this message:
Example failure: https://travis-ci.org/pytest-dev/pytest/jobs/444989259