Skip to content

Fix MacOS py37 on Travis #4217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blueyed merged 1 commit into from
Oct 24, 2018
Merged

Fix MacOS py37 on Travis #4217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ jobs:
env: TOXENV=py37
before_install:
- brew update
# remove c++ include files because upgrading python as of 2018-10-23, also
# attempts to upgrade gcc, and it fails because the include files already
# exist. removing the include files is one of the solutions recommended by brew
# this workaround might not be necessary in the future
- rm '/usr/local/include/c++'
Copy link
Member Author

@nicoddemus nicoddemus Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following what brew recommends in its error message:

	Could not symlink include/c++
	Target /usr/local/include/c++
	already exists. You may want to remove it:
	  rm '/usr/local/include/c++'

@jaraco does this seem correct to you? Any other suggestion?

Copy link
Member Author

@nicoddemus nicoddemus Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I'm mis-remembering, who contributed the macos builds was not @jaraco.

@jirikuncar what do you think?

Copy link
Contributor

@blueyed blueyed Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this symlink in the Travis image already? You might want to ls -l it in the beginning.

Copy link
Contributor

@blueyed blueyed Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens when also upgrading numpy (https://travis-ci.org/pytest-dev/pytest/jobs/444989259#L933), which maybe can be avoided with some option to "brew upgrade python" to not upgrade dependents? (should be faster then, too)

- brew upgrade python
- brew unlink python
- brew link python
Expand Down