[4.6.x] Fix one issue for compat::getfuncargnames#6785
Closed
SeanXu1984 wants to merge 4 commits intopytest-dev:4.6.xfrom
Closed
[4.6.x] Fix one issue for compat::getfuncargnames#6785SeanXu1984 wants to merge 4 commits intopytest-dev:4.6.xfrom
SeanXu1984 wants to merge 4 commits intopytest-dev:4.6.xfrom
Conversation
…funcargnames because it is already removed from signature(function)
…funcargnames because it is already removed from signature(function)
…funcargnames because it is already removed from signature(function)
Author
|
@nicoddemus I don't think the CI failure was introduced by my change. Could you help me with this please? |
Member
|
Travis seems to fail with tmpdir cleanup |
…funcargnames because it is already removed from signature(function)
4 tasks
Member
|
I've edited the title to add |
Member
|
@SeanXu1984 - it looks like this issue also affects the
|
RonnyPfannschmidt
requested changes
Jun 2, 2020
Member
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
as far as i can tell this one tries to add bound methods, which is not something pytest itself collects
we need a accompanying unit-test at least and a reference for the usage, else its bound to cause confusion later on
also in order to be integrated properly we need it as feature in master and do a back-port later on
Author
|
I've created another PR for main branch. #6882 |
Member
|
Closing for now as in #6882. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix so the self of an instancemethod will not be removed again in getfuncargnames because it is already removed from signature(function)
I will deal with changelog later.