Skip to content

Fix one issue for compat::getfuncargnames#6882

Closed
SeanXu1984 wants to merge 1 commit intopytest-dev:masterfrom
SeanXu1984:fix-getfuncargnames-issue
Closed

Fix one issue for compat::getfuncargnames#6882
SeanXu1984 wants to merge 1 commit intopytest-dev:masterfrom
SeanXu1984:fix-getfuncargnames-issue

Conversation

@SeanXu1984
Copy link

Fix so the self of an instancemethod will not be removed again in getfuncargnames because it is already removed from signature(function)

I will deal with changelog later.

@bluetech
Copy link
Member

Hi @SeanXu1984,

Your PR title says [pytest-5.3.x] but you target the master branch. If the problem exists in master, it should indeed be targeted at master first, and afterwards can be backported separately as needed. In this case [pytest-5.3.x] should be removed from this PR.

To understand the issue a little better, would you be able to add a test which demonstrates the issue? This will also prevent it from regressing.

@SeanXu1984
Copy link
Author

Hi, the issue description can be found from #6750
It was found in pytest-4.6.x but I believe it should be a issue for pytest 4.6.x as well.

@bluetech bluetech changed the title [pytest-5.3.x] - Fix one issue for compat::getfuncargnames Fix one issue for compat::getfuncargnames Apr 11, 2020
@bluetech
Copy link
Member

OK, so I've edited the title now as this PR should be the main one.

To proceed with this, please add a test case to the PR which fails before your fix and passes after. It is a bit difficult to assess otherwise.

@nicoddemus
Copy link
Member

Hi @SeanXu198,

First of all we would like to thank you for your time and effort on working on this, the pytest team deeply appreciates it.

We noticed it has been awhile since you have updated this PR, however. pytest is a high activity project, with many issues/PRs being opened daily, so it is hard for us maintainers to track which PRs are ready for merging, for review, or need more attention.

So for those reasons we think it is best to close the PR for now, but with the only intention to cleanup our queue, it is by no means a rejection of your changes. We still encourage you to re-open this PR (it is just a click of a button away) when you are ready to get back to it.

Again we appreciate your time for working on this, and hope you might get back to this at a later time!

Cheers,

@nicoddemus nicoddemus closed this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants