Fix one issue for compat::getfuncargnames#6882
Fix one issue for compat::getfuncargnames#6882SeanXu1984 wants to merge 1 commit intopytest-dev:masterfrom
Conversation
|
Hi @SeanXu1984, Your PR title says To understand the issue a little better, would you be able to add a test which demonstrates the issue? This will also prevent it from regressing. |
|
Hi, the issue description can be found from #6750 |
|
OK, so I've edited the title now as this PR should be the main one. To proceed with this, please add a test case to the PR which fails before your fix and passes after. It is a bit difficult to assess otherwise. |
|
Hi @SeanXu198, First of all we would like to thank you for your time and effort on working on this, the pytest team deeply appreciates it. We noticed it has been awhile since you have updated this PR, however. pytest is a high activity project, with many issues/PRs being opened daily, so it is hard for us maintainers to track which PRs are ready for merging, for review, or need more attention. So for those reasons we think it is best to close the PR for now, but with the only intention to cleanup our queue, it is by no means a rejection of your changes. We still encourage you to re-open this PR (it is just a click of a button away) when you are ready to get back to it. Again we appreciate your time for working on this, and hope you might get back to this at a later time! Cheers, |
Fix so the self of an instancemethod will not be removed again in getfuncargnames because it is already removed from signature(function)
I will deal with changelog later.