Prepare release 7.0.0rc1 by github-actions[bot] · Pull Request #8814 · pytest-dev/pytest

github-actions · 2021-06-28T19:22:02Z

Created automatically from manual trigger.

Once all builds pass and it has been approved by one or more maintainers, the build
can be released by pushing a tag 7.0.0rc1 to this repository.

nicoddemus

Thanks for managing the release @The-Compiler!

Left some comments.

nicoddemus · 2021-06-28T19:40:28Z

doc/en/changelog.rst


 .. towncrier release notes start

+pytest 7.0.0rc1 (2021-06-28)


Strange, this should be:

Suggested change

pytest 7.0.0rc1 (2021-06-28)

pytest 7.0.0rc1 (2021-06-28)

============================

No idea, seems like a town crier problem? 🤔

nicoddemus · 2021-06-28T19:43:55Z

doc/en/how-to/cache.rst

    --------------------------- cache values for '*' ---------------------------
    cache/lastfailed contains:
-      {'test_50.py::test_num[17]': True,
+      {'a/test_db.py::test_a1': True,


Hmmm with the documentation moved we are getting cache data from other runs. @RonnyPfannschmidt can we use "regendoc wipe" to fix this?

indeed, i believe this one needs a wipe

What does that mean exactly?

Hmm looking at it more carefully, we already have a regendoc:wipe in The new config.cache object a few lines above. Seems like regendoc:wipe might not be deleting the .pytest_cache directory?

nicoddemus · 2021-06-28T19:46:33Z

doc/en/how-to/usage.rst

-    ========================= short test summary info ==========================
-    FAILED test_example.py::test_fail - assert 0
-    ERROR test_example.py::test_error - assert 0
+    Traceback (most recent call last):


Oh we missed a import sys in the code above it (I can't suggest a change because it is not part of the diff :/)

The-Compiler

First pass over the diff... We have some stuff to take care of before we can proceed I'd say! Not sure how to best proceed here: Fix things in this PR, or abort the release, fix stuff, then go for it again? What do you think?

The-Compiler · 2021-06-28T19:23:44Z

doc/en/announce/release-7.0.0rc1.rst

+
+pytest 7.0.0rc1 has just been released to PyPI.
+
+This is a bug-fix release, being a drop-in replacement. To upgrade::


Ugh, lies... This is because the release script does:

pytest/scripts/release.py

Lines 25 to 27 in 1d67553

template_name = (

"release.minor.rst" if version.endswith(".0") else "release.patch.rst"

)

time to parse it with packaging to manage th e parts better

I'd rather just pass the --major flag we pass to prepare-release-pr.py already through to release.py instead of relying on parsing the version number to guess information we already have.

The-Compiler · 2021-06-28T19:24:47Z

doc/en/changelog.rst


 .. towncrier release notes start

+pytest 7.0.0rc1 (2021-06-28)


broken title?

The-Compiler · 2021-06-28T19:26:26Z

doc/en/changelog.rst

+  - ``_pytest.config.argparsing.Parser``
+  - ``_pytest.config.argparsing.OptionGroup``
+
+  These have always been considered private, but now issue a deprecation warning, which may become a hard error in pytest 7.0.0.


Suggested change

These have always been considered private, but now issue a deprecation warning, which may become a hard error in pytest 7.0.0.

These have always been considered private, but now issue a deprecation warning, which may become a hard error in pytest 8.0.0.

The-Compiler · 2021-06-28T19:26:53Z

doc/en/changelog.rst

+- `#8242 <https://github.com/pytest-dev/pytest/issues/8242>`_: Raising :class:`unittest.SkipTest` to skip collection of tests during the
+  pytest collection phase is deprecated. Use :func:`pytest.skip` instead.
+
+  Note: This deprecation only relates to using `unittest.SkipTest` during test


Suggested change

Note: This deprecation only relates to using `unittest.SkipTest` during test

Note: This deprecation only relates to using :class:`unittest.SkipTest` during test

The-Compiler · 2021-06-28T19:28:54Z

doc/en/changelog.rst

+
+
+- `#8315 <https://github.com/pytest-dev/pytest/issues/8315>`_: Several behaviors of :meth:`Parser.addoption <pytest.Parser.addoption>` are now
+  scheduled for removal in pytest 7 (deprecated since pytest 2.4.0):


Suggested change

scheduled for removal in pytest 7 (deprecated since pytest 2.4.0):

scheduled for removal in pytest 8 (deprecated since pytest 2.4.0):

The-Compiler · 2021-06-28T19:49:45Z

doc/en/changelog.rst

+- `#8503 <https://github.com/pytest-dev/pytest/issues/8503>`_: :meth:`pytest.MonkeyPatch.syspath_prepend` no longer fails when
+  ``setuptools`` is not installed.
+  It now only calls :func:`pkg_resources.fixup_namespace_packages` if
+  ``pkg_resources`` was previously imported, because it is not needed otherwise.


Internal or bugfix?

The-Compiler · 2021-06-28T19:50:10Z

doc/en/example/nonpython.rst

+      see https://docs.pytest.org/en/latest/deprecations.html#node-fspath-in-favor-of-pathlib-and-node-path
+        return self.fspath, 0, f"usecase: {self.name}"
+
+    -- Docs: https://docs.pytest.org/en/stable/warnings.html


Looks like something we should fix in the example

The-Compiler · 2021-06-28T19:50:17Z

doc/en/example/nonpython.rst

+      see https://docs.pytest.org/en/latest/deprecations.html#node-fspath-in-favor-of-pathlib-and-node-path
+        return self.fspath, 0, f"usecase: {self.name}"
+
+    -- Docs: https://docs.pytest.org/en/stable/warnings.html


The-Compiler · 2021-06-28T19:51:07Z

doc/en/how-to/cache.rst

    cachedir: $PYTHON_PREFIX/.pytest_cache
    --------------------------- cache values for '*' ---------------------------
    cache/lastfailed contains:
-      {'test_50.py::test_num[17]': True,


Hm, I don't understand those. Why is there suddenly so much more in there?

The-Compiler · 2021-06-28T19:52:12Z

doc/en/how-to/usage.rst

+    Traceback (most recent call last):
+      File "myinvoke.py", line 10, in <module>
+        sys.exit(pytest.main(["-qq"], plugins=[MyPlugin()]))
+    NameError: name 'sys' is not defined


Looks like #8800 broke this, cc @Srip

RonnyPfannschmidt · 2021-06-28T19:58:11Z

doc/en/builtin.rst

-            `#7767 <https://github.com/pytest-dev/pytest/issues/7767>`__ for details.
-
-    caplog
+    caplog -- ../../..$PYTHON_PREFIX/lib/python3.8/site-packages/_pytest/logging.py:476


those look broken

How so?

(edit: As in: I guess they could be cleaned up a bit, but they look as designed right now)

RonnyPfannschmidt · 2021-06-28T20:02:44Z

@The-Compiler t first glance most things look minor, if its quickly finished, just push it here, else lets put it into extra prs

The-Compiler · 2021-06-29T09:34:17Z

There's too much different stuff in here IMHO to fix it all as part of the release PR. I'm closing this (and removing the release branch), and instead opened new issues to track everything.

If there's a new contributor reading this: A couple of those would be a great first issue, and fixing it would accelerate the 7.0 release!

Prepare release version 7.0.0rc1

38a1561

nicoddemus requested changes Jun 28, 2021

View reviewed changes

The-Compiler requested changes Jun 28, 2021

View reviewed changes

RonnyPfannschmidt reviewed Jun 28, 2021

View reviewed changes

The-Compiler closed this Jun 29, 2021

The-Compiler deleted the release-7.0.0rc1 branch June 29, 2021 09:34

The-Compiler mentioned this pull request Jun 29, 2021

fix #8820 - ensure the release scripts are ware of release candidates #8825

Closed


		.. towncrier release notes start

		pytest 7.0.0rc1 (2021-06-28)


		pytest 7.0.0rc1 has just been released to PyPI.

		This is a bug-fix release, being a drop-in replacement. To upgrade::

	template_name = (
	"release.minor.rst" if version.endswith(".0") else "release.patch.rst"
	)

	These have always been considered private, but now issue a deprecation warning, which may become a hard error in pytest 7.0.0.
	These have always been considered private, but now issue a deprecation warning, which may become a hard error in pytest 8.0.0.

	Note: This deprecation only relates to using `unittest.SkipTest` during test
	Note: This deprecation only relates to using :class:`unittest.SkipTest` during test



		- `#8315 <https://github.com/pytest-dev/pytest/issues/8315>`_: Several behaviors of :meth:`Parser.addoption <pytest.Parser.addoption>` are now
		scheduled for removal in pytest 7 (deprecated since pytest 2.4.0):

	scheduled for removal in pytest 7 (deprecated since pytest 2.4.0):
	scheduled for removal in pytest 8 (deprecated since pytest 2.4.0):

Uh oh!

Conversation

github-actions bot commented Jun 28, 2021

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

The-Compiler left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

The-Compiler Jun 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RonnyPfannschmidt commented Jun 28, 2021

Uh oh!

The-Compiler commented Jun 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

The-Compiler Jun 28, 2021 •

edited

Loading