fix #8820 - ensure the release scripts are ware of release candidates#8825
Closed
RonnyPfannschmidt wants to merge 1 commit intopytest-dev:mainfrom
Closed
Conversation
…candidates as part of this i started to use packaging
The-Compiler
requested changes
Jun 29, 2021
| @@ -0,0 +1 @@ | |||
| Ensure prereleases correctly pick the matching changelog template. | |||
Member
There was a problem hiding this comment.
Not an user-facing bugfix, so this seems confusing.
| template_name = ( | ||
| "release.minor.rst" if version.endswith(".0") else "release.patch.rst" | ||
| ) | ||
| template_name = "release.minor.rst" if version.minor == 0 else "release.patch.rst" |
Member
There was a problem hiding this comment.
Have you seen my suggestions:
- In Fix release announcement script for prereleases #8820 (comment) regarding adding a template for prereleases
- In Prepare release 7.0.0rc1 #8814 (comment) regarding passing through this information from
prepare-release-pr.pyrather than trying to infer it again from the version number
?
Member
Author
There was a problem hiding this comment.
Missed it before, will check the details, thanks
Member
Author
|
closing a superseded and fixed by another pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as part of this i started to use packaging