The default buffer size is fine for 99% of pipe operations#204
Merged
tleonhardt merged 1 commit intomasterfrom Aug 10, 2017
Merged
The default buffer size is fine for 99% of pipe operations#204tleonhardt merged 1 commit intomasterfrom
tleonhardt merged 1 commit intomasterfrom
Conversation
Removed the complexity of a member variable which would be unnecessary for the vast majority of applications. If users have an application with atypical requirements, they are free to override the default.
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 96.81% 96.81% -0.01%
==========================================
Files 1 1
Lines 1162 1161 -1
==========================================
- Hits 1125 1124 -1
Misses 37 37
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the complexity of a member variable which would be unnecessary for the vast majority of applications.
If users have an application with atypical requirements, they are free to override the default.