Skip to content

The default buffer size is fine for 99% of pipe operations #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tleonhardt merged 1 commit into from
Aug 10, 2017
Merged

The default buffer size is fine for 99% of pipe operations #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions cmd2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,6 @@ def __init__(self, completekey='tab', stdin=None, stdout=None, use_ipython=False
# Used when piping command output to a shell command
self.pipe_proc = None

# Size of the stdin/stdout buffers used when piping command output to a shell command via self.stdout.
# This should be increased in cases where large amounts of data are expected to be piped to the shell
# to prevent blocking when writing to self.stdout.
self._pipe_buffer_size = io.DEFAULT_BUFFER_SIZE

# ----- Methods related to presenting output to the user -----

@property
Expand Down Expand Up @@ -816,9 +811,9 @@ def _redirect_output(self, statement):

# Open each side of the pipe and set stdout accordingly
# noinspection PyTypeChecker
self.stdout = io.open(write_fd, write_mode, buffering=self._pipe_buffer_size)
self.stdout = io.open(write_fd, write_mode)
# noinspection PyTypeChecker
subproc_stdin = io.open(read_fd, read_mode, buffering=self._pipe_buffer_size)
subproc_stdin = io.open(read_fd, read_mode)

# We want Popen to raise an exception if it fails to open the process. Thus we don't set shell to True.
try:
Expand Down