Skip to content

Conversation

@kotfu
Copy link
Member

@kotfu kotfu commented May 4, 2018

@kotfu kotfu requested a review from tleonhardt as a code owner May 4, 2018 23:00
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #387 into master will increase coverage by 0.59%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   88.98%   89.58%   +0.59%     
==========================================
  Files           8        8              
  Lines        2615     2630      +15     
==========================================
+ Hits         2327     2356      +29     
+ Misses        288      274      -14
Impacted Files Coverage Δ
cmd2/cmd2.py 90.81% <96.66%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92fdf41...f826598. Read the comment docs.

@kotfu kotfu self-assigned this May 4, 2018
@tleonhardt tleonhardt added this to the 0.9.0 milestone May 5, 2018
else:
self.poutput(hi.pr())

def _generate_transcript(self, history, transcript_file):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring and improving this.

('dotstar.txt', False),
('extension_notation.txt', False),
# ('from_cmdloop.txt', True),
('from_cmdloop.txt', True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these

@tleonhardt tleonhardt merged commit 132a788 into master May 5, 2018
@tleonhardt tleonhardt deleted the transcript_tests branch May 5, 2018 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants