Skip to content

Conversation

@mikelolasagasti
Copy link
Contributor

@mikelolasagasti mikelolasagasti commented Jan 2, 2023

Running current proposed command:

xgettext --from-code=UTF-8 -o humanize.pot -k'_' -k'N_' -k'P_:1c,2' -l python src/humanize/*.py 
$ pocount humanize.pot |grep Total
Total:           45                60                      0

Adding missing _NS and _ngettext keys:

xgettext --from-code=UTF-8 -o humanize.pot -k'_' -k'N_' -k'P_:1c,2' -k'NS_:1,2' -k'_ngettext:1,2' -l python src/humanize/*.py
$ pocount humanize.pot |grep Total
Total:           67               132                      0

Add the following missing strings:

+msgid "thousand"
+msgid_plural "thousand"
+msgid "million"
+msgid_plural "million"
+msgid "billion"
+msgid_plural "billion"
+msgid "trillion"
+msgid_plural "trillion"
+msgid "quadrillion"
+msgid_plural "quadrillion"
+msgid "quintillion"
+msgid_plural "quintillion"
+msgid "sextillion"
+msgid_plural "sextillion"
+msgid "septillion"
+msgid_plural "septillion"
+msgid "octillion"
+msgid_plural "octillion"
+msgid "nonillion"
+msgid_plural "nonillion"
+msgid "decillion"
+msgid_plural "decillion"
+msgid "googol"
+msgid_plural "googol"
+msgid "%d microsecond"
+msgid_plural "%d microseconds"
+msgid "%d millisecond"
+msgid_plural "%d milliseconds"
+msgid "%d second"
+msgid_plural "%d seconds"
+msgid "%d minute"
+msgid_plural "%d minutes"
+msgid "%d hour"
+msgid_plural "%d hours"
+msgid "%d day"
+msgid_plural "%d days"
+msgid "%d month"
+msgid_plural "%d months"
+msgid "1 year, %d day"
+msgid_plural "1 year, %d days"
+msgid "1 year, %d month"
+msgid_plural "1 year, %d months"
+msgid "%d year"
+msgid_plural "%d years"

@hugovk
Copy link
Member

hugovk commented Jan 3, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #83 (dfe6681) into main (8f37b1c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files           9        9           
  Lines         745      745           
=======================================
  Hits          738      738           
  Misses          7        7           
Flag Coverage Δ
macos-latest 97.44% <ø> (ø)
ubuntu-latest 97.44% <ø> (ø)
windows-latest 95.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mikelolasagasti
Copy link
Contributor Author

Yes, it should. Pushed a new amended commit adding the modified scripts/update-translations.sh script.

@hugovk hugovk added the changelog: Added For new features label Jan 8, 2023
@hugovk
Copy link
Member

hugovk commented Jan 8, 2023

Thank you! I've updated this PR to run the script and update the translations:

How does that look?

@hugovk hugovk merged commit a759dd9 into python-humanize:main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Added For new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants