Release Pillow 5.4.1

[hugovk]

Follow on from 5.4.0 (#3391).

TODO:

• Fix PNG MIME type regression: Add apng extension to png plugin #3501 (comment) / PR Detect mimetypes #3525 (cherry pick just the PNG fix)
  • Merge to master
  • Cherry picked
• Fix Termux regression: Pillow 5.4.0 cannot be installed on Termux #3526 / PR: Fix build for Termux #3529
  • Merge to master
  • Cherry picked
• Fix PNG "IDAT chunks after image end" regression: Error when loading some PNG images #3527 / PR Handle IDAT chunks after image end #3532
  • Merge to master
  • Cherry picked
• Fix file closing regression: Cannot read TIFF file #3536 / PR Only close __fp if not fp #3540
  • Merge to master
  • Cherry picked
• Release notes: PRs Add 5.4.1 release notes #3544 & Added release notes for #3540 #3553
  • Merge to master
  • Cherry picked

Point Release

Released as needed for security, installation or critical bug fixes.

• Make necessary changes in master branch.
• Update CHANGES.rst.
• Cherry pick individual commits from master branch to release branch e.g. 5.4.x.
• Check Travis CI to confirm passing tests in release branch e.g. 5.4.x.
• Check out release branch e.g.:

    git checkout -t remotes/origin/5.4.x

• In compliance with PEP 440, update version identifier in src/PIL/_version.py
• Run pre-release check via make release-test.
• Create tag for release e.g.:

    $ git tag 5.4.1
    $ git push --tags

• Create source distributions e.g.:

    $ make sdist

• Create binary distributions
• Create a new release on GitHub

Binary Distributions

Windows

• Contact @cgohlke for Windows binaries via release ticket e.g. Release 2.9.0 on July 1, 2015 #1174.
• Download and extract tarball from @cgohlke and twine upload *.

Mac and Linux

• Use the Pillow Wheel Builder:

    $ git clone https://github.com/python-pillow/pillow-wheels
    $ cd pillow-wheels
    $ git submodule init
    $ git submodule update Pillow
    $ cd Pillow
    $ git fetch --all
    $ git checkout [[release tag]]
    $ cd ..
    $ git commit -m "Pillow -> 5.4.1" Pillow
    $ git push

• Download distributions from the Pillow Wheel Builder container.

Publicize Release

• Announce release availability via Twitter e.g. https://twitter.com/PythonPillow/status/1013789184354603010

Documentation

• Make sure the default version for Read the Docs is the latest tagged release e.g. d2d43879 (5.4.1)

[hugovk]

Thoughts on including the PNG "IDAT chunks after image end" regression?

#3527 / PR #3532

[aclark4life]

@wiredfool ^^^ ?

[wiredfool]

Yeah, it's a regression. It's been reported, we have a fix, we're doing the release. Put it in.

[hugovk]

Added to the list. I'll do the release this weekend.

[radarhere]

#3540? In #3536, an OSError: cannot identify image file became ValueError: seek of closed file in 5.4.0.

[hugovk]

#3540? In #3536, an OSError: cannot identify image file became ValueError: seek of closed file in 5.4.0.

If there's no objections by tomorrow, let's include it. Please could you update the 5.4.1 release notes?

[hugovk]

A question about the release checklist for point releases:

...

• Cherry pick individual commits from master branch to release branch e.g. 5.2.x.
• Check Travis CI to confirm passing tests in release branch e.g. 5.2.x.
• Check out release branch e.g.:

    git checkout -t remotes/origin/5.2.x

• In compliance with PEP 440, update version identifier in src/PIL/_version.py

...

Presumably that git checkout -t remotes/origin/5.2.x should really come before the cherry picks?

[aclark4life]

@hugovk Sounds about right. I don't think you can specify a target branch when cherry-picking …

[hugovk]

@cgohlke Please could we have Windows binaries for 5.4.1?

[cgohlke]

Here you go.

[hugovk]

@cgohlke Thanks!

---

5.4.1 is all uploaded and released, bar Twitter and Read the Docs.

RTD has got jammed again... I've started a manual build of stable.