Merged
Conversation
`_find_library_dirs_ldconfig` can return an empty list when `ldconfig` is missing, then `setup.py` can continue guessing library directories. fixes python-pillow#3526
Contributor
Author
|
@valpogus I not really built Pillow on Termux because I didn't found zlib. I simply removed the error. The directories at #1957 (comment) are standard? My device isn't rooted so maybe you can look it for me if the headers are there and maybe add headers search paths specific for Termux. What is supposed to be inside Edit: |
Contributor
|
yup. it works now |
Member
|
Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
_find_library_dirs_ldconfigreturns an empty list whenldconfigis missing, thensetup.pycan continue guessing library directories.Fixes #3526.