Skip to content

Ignore PyTest 5.4.2#4623

Closed
nulano wants to merge 1 commit intopython-pillow:masterfrom
nulano:pytest-3.9
Closed

Ignore PyTest 5.4.2#4623
nulano wants to merge 1 commit intopython-pillow:masterfrom
nulano:pytest-3.9

Conversation

@nulano
Copy link
Copy Markdown
Contributor

@nulano nulano commented May 13, 2020

Python 3.9-pre tests have started failing recently, with a segmentation fault in PyTest rewrite during collection: https://travis-ci.org/github/python-pillow/Pillow/jobs/686090749#L2777

Pinning pytest!=5.4.2 to force PyTest 5.4.1 seems to fix this.

@nulano
Copy link
Copy Markdown
Contributor Author

nulano commented May 13, 2020

@nulano
Copy link
Copy Markdown
Contributor Author

nulano commented May 13, 2020

Looks like it is not passing in this repo, even though it passed in mine.

Additionally, PyTest 5.4.2 actually passes in my repo as well (my pr #4615): https://travis-ci.org/github/nulano/Pillow/jobs/684984552#L2666 (I didn't check because I thought it was older, sorry for the noise)

@nulano nulano closed this May 13, 2020
@hugovk
Copy link
Copy Markdown
Member

hugovk commented May 13, 2020

Good finding!

It's failing on my fork too.

I diffed your passing log and the failing upstream one, and the first think I noticed is that upstream is using a cache for pip, and yours is downloading fresh files.

I deleted the Travis caches on my fork, and 3.9 now passes!

I've deleted caches for upstream too and triggered a fresh build:

@hugovk
Copy link
Copy Markdown
Member

hugovk commented May 13, 2020

And it passed!

https://travis-ci.org/github/python-pillow/Pillow/jobs/686544749

@nulano nulano deleted the pytest-3.9 branch May 13, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants