Skip to content

Glob to find stale dist-infos#137

Closed
nickray wants to merge 1 commit into
python-poetry:masterfrom
nickray:wheel-builder-dist-info-glob
Closed

Glob to find stale dist-infos#137
nickray wants to merge 1 commit into
python-poetry:masterfrom
nickray:wheel-builder-dist-info-glob

Conversation

@nickray
Copy link
Copy Markdown

@nickray nickray commented Mar 1, 2021

This is a preparation for python-poetry/poetry#3742.

It seems the sibling method is not documented/tested, so not clear what to do on that front.
Alternative might be to pass through name in dist_info_name unescaped if it's the *-glob?

@nickray nickray force-pushed the wheel-builder-dist-info-glob branch from 75ce3c0 to 38734c3 Compare March 4, 2021 10:00
@nickray nickray marked this pull request as ready for review March 4, 2021 10:06
@abn
Copy link
Copy Markdown
Member

abn commented Mar 20, 2021

Hi @nickray thank you for the change. Looking at the desired change, I am not sure if this needs to be here per-say. This can be, and imho should be, done poetry side without core changes.

@abn
Copy link
Copy Markdown
Member

abn commented Apr 11, 2021

Closing. See python-poetry/poetry#3742 (comment).

@abn abn closed this Apr 11, 2021
@nickray nickray deleted the wheel-builder-dist-info-glob branch April 13, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants