Remove all globbed dist-infos in editable self-installs#3742
Conversation
nickray
force-pushed
the
remove-stale-editable-dist-infos
branch
5 times, most recently
from
1407dcd to
6acb4dd
Compare
|
This was mostly good to go, until a change in poetry-core/master broke the poetry/master build. How to proceed? |
nickray
force-pushed
the
remove-stale-editable-dist-infos
branch
from
6acb4dd to
322b546
Compare
nickray
force-pushed
the
remove-stale-editable-dist-infos
branch
from
322b546 to
2c5ee7f
Compare
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
You could add a find_glob method to SitePackages. That might be the clean way forward.
| dist_info_paths = [ | ||
| Path(dist_info) | ||
| for site_package_dir in self._env.site_packages.writable_candidates | ||
| for dist_info in site_package_dir.glob(builder.dist_info_glob) |
There was a problem hiding this comment.
Since the glob is only really required for an editable builder; you can construct it here.
There was a problem hiding this comment.
I can, sure. If I do, though, the glob "{}-*.dist-info".format(escaped_name) depends on implementation details of core (structure of format string, implementation of escape_name(self._package.name)), which I felt was iffy.
|
This issue is of interest to me, is there anything I can do to help? |
|
@stephsamson @abn maybe this should be closed now that #3900 was merged? |
|
Superseded by #3900. Thanks @fredrikaverpil |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Pull Request Check List
Resolves: #2918, #3741, partially #2855.
Depends on: python-poetry/poetry-core#137
The
SitePackagesclass seems not quite made for globbing. Appreciate pointers if there is a better way..This depends on python-poetry/poetry-core#137 to avoid code duplication, might be easier to just implement the method from there here.