Skip to content

Replace python-check-blanket-type-ignore with ignore-without-code in mypy#350

Merged
neersighted merged 2 commits into
python-poetry:masterfrom
mkniewallner:enable-ignore-without-code-mypy
May 11, 2022
Merged

Replace python-check-blanket-type-ignore with ignore-without-code in mypy#350
neersighted merged 2 commits into
python-poetry:masterfrom
mkniewallner:enable-ignore-without-code-mypy

Conversation

@mkniewallner
Copy link
Copy Markdown
Member

This PR basically applies the same change that was merged in python-poetry/poetry#5535.

  • Added tests for changed code. Not applicable
  • Updated documentation for changed code. Not applicable

The hook is now obsolete, since `ignore-without-code` from `mypy` already checks for too broad `# type: ignore`
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@neersighted neersighted merged commit 79ba1d8 into python-poetry:master May 11, 2022
@mkniewallner mkniewallner deleted the enable-ignore-without-code-mypy branch May 11, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants