Replace python-check-blanket-type-ignore with ignore-without-code in mypy#5535
Merged
abn merged 2 commits intoMay 9, 2022
Conversation
The hook is now obsolete, since `ignore-without-code` from `mypy` already checks for too broad `# type: ignore`
Member
Author
|
Force-pushed the branch, since there was a conflict following the merge of #5531. |
abn
approved these changes
May 9, 2022
This was referenced May 10, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository today relies on
python-check-blanket-type-ignorefrom https://github.com/pre-commit/pygrep-hooks to ensure that all# type: ignoreignore specific error codes.While this works, version
0.940ofmypyadded a way to enforce that through an optional error code (python/mypy#11633).The main advantage of using this rather than the regex is that the error code indicates the specific error code(s) to ignore in case a too broad
# type: ignoreis added.To showcase that, you can see
pre-commitoutput here, extracted from this change based on this PR's branch.Pull Request Check List
Added tests for changed code.Not applicableUpdated documentation for changed code.Not applicable