Skip to content

Relax licence restrictions to support custom licences#5

Merged
abn merged 2 commits into
python-poetry:masterfrom
abn:custom-licenses
Apr 1, 2020
Merged

Relax licence restrictions to support custom licences#5
abn merged 2 commits into
python-poetry:masterfrom
abn:custom-licenses

Conversation

@abn
Copy link
Copy Markdown
Member

@abn abn commented Mar 27, 2020

This change adds support of use of custom licenses for projects. If the
value specified for licence is not in the SPDX License List or
"Proprietary", we treat it as a custom licence withe value (as is) as
the name.

As a side-effect, the validation of licence is no longer performed when
executing poetry check.

Resolves: python-poetry/poetry#2020

abn added 2 commits March 27, 2020 16:36
Copy over old test cases from poetry repository.
This change adds support of use of custom licenses for projects. If the
value specified for `licence` is not in the SPDX License List or
"Proprietary", we treat it as a custom licence withe value (as is) as
the name.

As a side-effect, the validation of licence is no longer performed when
executing `poetry check`.

Resolves: python-poetry/poetry#2020
Copy link
Copy Markdown
Member

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is sound and I would like to see this merged. @sdispater are there any concerns on your end about this feature?

@abn
Copy link
Copy Markdown
Member Author

abn commented Apr 1, 2020

This was okayed on discored.

@abn abn merged commit d62352f into python-poetry:master Apr 1, 2020
@abn abn deleted the custom-licenses branch April 1, 2020 19:11
@sdispater sdispater mentioned this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for named Other/Proprietary Licenses

2 participants