Skip to content

Relax licence restrictions to support custom licences#2202

Closed
abn wants to merge 2 commits into
python-poetry:developfrom
abn:issue/2020
Closed

Relax licence restrictions to support custom licences#2202
abn wants to merge 2 commits into
python-poetry:developfrom
abn:issue/2020

Conversation

@abn
Copy link
Copy Markdown
Member

@abn abn commented Mar 19, 2020

This change adds support of use of custom licenses for projects. If the
value specified for licence is not in the SPDX License List or
"Proprietary", we treat it as a custom licence withe value (as is) as
the name.

As a side-effect, the validation of licence is no longer performed when
executing poetry check.

Resolves: #2020 #2198

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

abn added 2 commits March 19, 2020 18:55
@abn
Add documentation for use of proprietary licence
18ecd8e 
Resolves: python-poetry#2198
@abn
Relax licence restrictions to support custom licences
fb2a2aa 
This change adds support of use of custom licenses for projects. If the
value specified for `licence` is not in the SPDX License List or
"Proprietary", we treat it as a custom licence withe value (as is) as
the name.

As a side-effect, the validation of licence is no longer performed when
executing `poetry check`.

Resolves: python-poetry#2020
@abn
Copy link
Copy Markdown
Member Author

abn commented Mar 19, 2020

This is probably the simplest change to support custom licences. The main reservation I had was that now, if someone makes a typo (eg: license = "MIIT") it will no longer be reported as an error. Which in the grand scheme of things, might not be an issue. But figured I'd mention it here, in case an alternative behavior is preferred.

@finswimmer finswimmer requested a review from a team March 20, 2020 15:56
@kasteph
Copy link
Copy Markdown
Member

kasteph commented Mar 27, 2020 •
edited
Loading

This is probably the simplest change to support custom licences. The main reservation I had was that now, if someone makes a typo (eg: license = "MIIT") it will no longer be reported as an error.

Maybe a simple distance measure could be used to catch such typos.

@kasteph kasteph added the kind/feature Feature requests/implementations label Mar 27, 2020
@abn
Copy link
Copy Markdown
Member Author

abn commented Mar 27, 2020

I feel it might be adding unnecessarily complexity without much guaretee in return. And, personally, I do not think the impact of a typo in the licence warrants such a safegueard. Besides, this can be added in later if we really need it.

@abn
Copy link
Copy Markdown
Member Author

abn commented Mar 27, 2020

This might need to move to https://github.com/python-poetry/core I think.

@abn
Copy link
Copy Markdown
Member Author

abn commented Mar 27, 2020

This has now been split into two PRs.

  1. Doc fix for use of proprietary licence (Add documentation for use of proprietary licence #2231)
  2. Custom license support for a future version of poetry-core (Relax licence restrictions to support custom licences poetry-core#5)

The documentation fix for (2) will be created if/when the version of poetry-core is merged.

@abn abn closed this Mar 27, 2020
@abn abn deleted the issue/2020 branch October 6, 2020 21:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/feature Feature requests/implementations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abn @kasteph