Improve package equality check and repr#53
Merged
Conversation
abn
force-pushed
the
improve-package-equality
branch
from
969d3cb to
f502500
Compare
abn
added a commit
to abn/poetry
that referenced
this pull request
Jul 27, 2020
Prior to this change, when checking solver results the tests cases relied on the weaker equality check of the `Package` class. With python-poetry/poetry-core#53, the check has been made stricter. This change, while having no functional impact, ensures that once poetry-core is updated, tests do not fail unexpectedly.
Member
Author
|
@sdispater any concerns on this one? |
abn
added a commit
to abn/poetry
that referenced
this pull request
Aug 10, 2020
Prior to this change, when checking solver results the tests cases relied on the weaker equality check of the `Package` class. With python-poetry/poetry-core#53, the check has been made stricter. This change, while having no functional impact, ensures that once poetry-core is updated, tests do not fail unexpectedly.
abn
added a commit
to abn/poetry
that referenced
this pull request
Aug 10, 2020
Prior to this change, when checking solver results the tests cases relied on the weaker equality check of the `Package` class. With python-poetry/poetry-core#53, the check has been made stricter. This change, while having no functional impact, ensures that once poetry-core is updated, tests do not fail unexpectedly.
finswimmer
pushed a commit
to python-poetry/poetry
that referenced
this pull request
Aug 15, 2020
Prior to this change, when checking solver results the tests cases relied on the weaker equality check of the `Package` class. With python-poetry/poetry-core#53, the check has been made stricter. This change, while having no functional impact, ensures that once poetry-core is updated, tests do not fail unexpectedly.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be a bit more stricter with how we compare packages as prior to this we would check two packages,
foo-1.0.0withsource_reference=xandfoo-1.0.0withsource_reference=yas the same. Which can lead to some unexpected issues at poetry runtime and incorrect validation in poetry's test suites as well.