tests/solver: validate correct packages#2732
Merged
Merged
Conversation
Prior to this change, when checking solver results the tests cases relied on the weaker equality check of the `Package` class. With python-poetry/poetry-core#53, the check has been made stricter. This change, while having no functional impact, ensures that once poetry-core is updated, tests do not fail unexpectedly.
abn
force-pushed
the
improve-test-solver
branch
from
b43d980 to
2a64914
Compare
finswimmer
approved these changes
Aug 15, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, when checking solver results the tests cases
relied on the weaker equality check of the
Packageclass. Withpython-poetry/poetry-core#53, the check has been made stricter.
This change, while having no functional impact, ensures that once
poetry-core is updated, tests do not fail unexpectedly.
Relates-to: python-poetry/poetry-core#53