Skip to content

Create a more structured pyproject.toml object#70

Merged
kasteph merged 3 commits intopython-poetry:masterfrom
abn:refactor/pyproject
Aug 27, 2020
Merged

Create a more structured pyproject.toml object#70
kasteph merged 3 commits intopython-poetry:masterfrom
abn:refactor/pyproject

Conversation

@abn
Copy link
Copy Markdown
Member

@abn abn commented Aug 24, 2020

This change is a step towards making interactions with pyproject.toml
files more structured and standardised.

Resolves: python-poetry/poetry#2851

  • Added tests for changed code.

@abn abn requested a review from a team August 24, 2020 18:59
@abn abn marked this pull request as ready for review August 24, 2020 18:59
@abn abn force-pushed the refactor/pyproject branch 4 times, most recently from 36dbd6a to 932be4b Compare August 24, 2020 19:19
Comment thread poetry/core/exceptions/__init__.py Outdated
Comment thread poetry/core/pyproject/__init__.py Outdated
Comment thread poetry/core/pyproject/toml.py
@abn abn force-pushed the refactor/pyproject branch from 932be4b to 01895b5 Compare August 27, 2020 08:08
@abn abn requested a review from kasteph August 27, 2020 08:09
abn added 2 commits August 27, 2020 10:11
This change is a step towards making interactions with pyproject.toml
files more structured and standardised.
@abn abn force-pushed the refactor/pyproject branch from 75d2580 to 10d17d2 Compare August 27, 2020 08:11
@abn
Copy link
Copy Markdown
Member Author

abn commented Aug 27, 2020

@stephsamson this should be ready again.

@kasteph kasteph merged commit 96a8542 into python-poetry:master Aug 27, 2020
@abn abn deleted the refactor/pyproject branch August 27, 2020 08:25
abn added a commit to abn/poetry that referenced this pull request Sep 26, 2020
This change unifies TOML and pyproject.toml file handling to core
classes to ensure consistent handling of TOML files.

Reference: python-poetry/poetry-core#70
Reference: python-poetry/poetry-core#74
finswimmer pushed a commit to python-poetry/poetry that referenced this pull request Sep 29, 2020
This change unifies TOML and pyproject.toml file handling to core
classes to ensure consistent handling of TOML files.

Reference: python-poetry/poetry-core#70
Reference: python-poetry/poetry-core#74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improved error message for EmptyKeyError

2 participants