Skip to content

Unify toml and pyproject file handling#2982

Merged
finswimmer merged 1 commit into
python-poetry:masterfrom
abn:toml
Sep 29, 2020
Merged

Unify toml and pyproject file handling#2982
finswimmer merged 1 commit into
python-poetry:masterfrom
abn:toml

Conversation

@abn
Copy link
Copy Markdown
Member

@abn abn commented Sep 26, 2020 •
edited
Loading

This change unifies TOML and pyproject.toml file handling to core
classes to ensure consistent handling of TOML files.

Reference: python-poetry/poetry-core#70
Reference: python-poetry/poetry-core#74

Resolves: #2851

This is a non-breaking change with no changes to behaviour.

Without this change the deprecated use of TomlFile raises the following warning:

DeprecationWarning: Use of poetry.core.utils.toml_file.TomlFile has been deprecated, use poetry.core.toml.file.TOMLFile instead.
    local_config_file = TomlFile(base_poetry.file.parent / "poetry.toml")

@abn
Unify toml and pyproject file handling
c62f6e7 
This change unifies TOML and pyproject.toml file handling to core
classes to ensure consistent handling of TOML files.

Reference: python-poetry/poetry-core#70
Reference: python-poetry/poetry-core#74
@abn abn requested a review from a team September 26, 2020 19:45
@abn abn added this to the 1.1 milestone Sep 26, 2020
@abn abn added the kind/bug Something isn't working as expected label Sep 26, 2020
@abn abn mentioned this pull request Sep 27, 2020
Closed
2 tasks
@abn abn removed the kind/bug Something isn't working as expected label Sep 27, 2020
@abn
Copy link
Copy Markdown
Member Author

abn commented Sep 28, 2020

@finswimmer can you review this one please?

@finswimmer finswimmer merged commit e49f093 into python-poetry:master Sep 29, 2020
@abn abn deleted the toml branch September 29, 2020 19:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

Improved error message for EmptyKeyError

2 participants

@abn @finswimmer