Skip to content

Fixed not sorted hashes in requirements.txt export#54

Merged
abn merged 3 commits into
python-poetry:mainfrom
cgkoutzigiannis:main
May 9, 2022
Merged

Fixed not sorted hashes in requirements.txt export#54
abn merged 3 commits into
python-poetry:mainfrom
cgkoutzigiannis:main

Conversation

@cgkoutzigiannis
Copy link
Copy Markdown
Contributor

@cgkoutzigiannis cgkoutzigiannis commented May 8, 2022


hashes.append(f"{algorithm}:{h}")

hashes.sort()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hashes.sort()
hashes.sort()

Nitpick.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abn abn merged commit 2734d39 into python-poetry:main May 9, 2022
@radoering radoering mentioned this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort hashes when exporting "requirements.txt"

2 participants