Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/poetry_plugin_export/exporter.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,8 @@ def _export_requirements_txt(self, cwd: Path, output: IO | str) -> None:

hashes.append(f"{algorithm}:{h}")

hashes.sort()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hashes.sort()
hashes.sort()

Nitpick.


for h in hashes:
line += f" \\\n --hash={h}"

Expand Down
48 changes: 48 additions & 0 deletions tests/test_exporter.py
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,54 @@ def test_exporter_can_export_requirements_txt_with_standard_packages_and_hashes(
assert content == expected


def test_exporter_can_export_requirements_txt_with_standard_packages_and_sorted_hashes(
tmp_dir: str, poetry: Poetry
):
poetry.locker.mock_lock_data(
{
"package": [
{
"name": "foo",
"version": "1.2.3",
"category": "main",
"optional": False,
"python-versions": "*",
},
{
"name": "bar",
"version": "4.5.6",
"category": "main",
"optional": False,
"python-versions": "*",
},
],
"metadata": {
"python-versions": "*",
"content-hash": "123456789",
"hashes": {"foo": ["67890", "12345"], "bar": ["67890", "12345"]},
},
}
)
set_package_requires(poetry)

exporter = Exporter(poetry)
exporter.export("requirements.txt", Path(tmp_dir), "requirements.txt")

with (Path(tmp_dir) / "requirements.txt").open(encoding="utf-8") as f:
content = f.read()

expected = f"""\
bar==4.5.6 ; {MARKER_PY} \\
--hash=sha256:12345 \\
--hash=sha256:67890
foo==1.2.3 ; {MARKER_PY} \\
--hash=sha256:12345 \\
--hash=sha256:67890
"""

assert content == expected


def test_exporter_requirements_txt_with_standard_packages_and_hashes_disabled(
tmp_dir: str, poetry: Poetry
):
Expand Down