feat(ci): switch to pre-commit.ci for code quality#4750
Merged
Conversation
neersighted
commented
Nov 13, 2021
neersighted
commented
Nov 13, 2021
neersighted
commented
Nov 13, 2021
neersighted
commented
Nov 13, 2021
neersighted
commented
Nov 13, 2021
neersighted
commented
Nov 13, 2021
neersighted
commented
Nov 13, 2021
neersighted
commented
Nov 13, 2021
neersighted
commented
Nov 13, 2021
Member
Author
|
Incidentally, it looks like pre-commit.ci is going to run against all future PR pulls. To avoid unwanted auto-fix commits as much as possible, I can create a reduced subset of this that just disables the auto-fix commits until the larger PR can be merged.
(screenshot from an unrelated PR) |
neersighted
force-pushed
the
neersighted/pre-commit.ci
branch
3 times, most recently
from
29d2027 to
15bf937
Compare
branchv
reviewed
Nov 14, 2021
neersighted
commented
Nov 14, 2021
neersighted
force-pushed
the
neersighted/pre-commit.ci
branch
2 times, most recently
from
1ef1b6d to
3a695eb
Compare
Member
Author
|
Fixed the failing checks by making the old |
abn
requested changes
Nov 14, 2021
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Changes look good to me. I'd request that we remove the commented out checks for now and enable them as and when we need them.
branchv
reviewed
Nov 14, 2021
neersighted
force-pushed
the
neersighted/pre-commit.ci
branch
from
3a695eb to
cfccf78
Compare
Member
Author
Done! |
neersighted
force-pushed
the
neersighted/pre-commit.ci
branch
from
cfccf78 to
1eb356d
Compare
code-quality.yaml / the `pre-commit` workflow are made a no-op to smooth the transition.
neersighted
force-pushed
the
neersighted/pre-commit.ci
branch
from
1eb356d to
2c83315
Compare
neersighted
force-pushed
the
neersighted/pre-commit.ci
branch
from
2c83315 to
9e8c88a
Compare
abn
reviewed
Nov 14, 2021
neersighted
force-pushed
the
neersighted/pre-commit.ci
branch
from
13719c9 to
0a5d7e5
Compare
The `debug resolve` had an extra row included in its table, adding extra whitespace. Also, remove a list that is discarded immediately.
neersighted
force-pushed
the
neersighted/pre-commit.ci
branch
from
0a5d7e5 to
b9fc2b1
Compare
abn
approved these changes
Nov 14, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit.ci is faster, and has less moving parts than our current Github Actions workflow. It integrates with Github checks, it can auto-correct PRs if desired (turned off in this PR), and it will automatically generate PRs to keep our
pre-commithooks up to date.Note that this PR won't actually show pre-commit.ci working until an organization admin enables it (additionally, the protected branch config will have to be updated).