handle importlib-metadata deprecation #7774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
reviewed
Apr 7, 2023
dimbleby
force-pushed
the
importlib-metadata-deprecation
branch
2 times, most recently
from
3f26265 to
246a65b
Compare
Contributor
Author
|
slightly surprised - in a good way - to see that importlib-metadata MR being merged already. So let's go back to the "use |
dimbleby
force-pushed
the
importlib-metadata-deprecation
branch
2 times, most recently
from
5fd43c0 to
3a31634
Compare
importlib-metadata promises that it will start raising KeyError for missing values, rather than returning None
dimbleby
force-pushed
the
importlib-metadata-deprecation
branch
from
3a31634 to
8c9cfaf
Compare
radoering
approved these changes
Apr 8, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/python/importlib_metadata/blob/main/CHANGES.rst#v520
python/importlib_metadata#416