Two small followups to gh-228#232
Merged
remleduff merged 2 commits intopython-trio:masterfrom Jun 21, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 99.09% 99.09% +<.01%
==========================================
Files 63 63
Lines 8466 8472 +6
Branches 610 610
==========================================
+ Hits 8389 8395 +6
Misses 61 61
Partials 16 16
Continue to review full report at Codecov.
|
Contributor
|
LGTM. Though looking at this diff in GitHub reminds me, I wonder if they use git to create the diff, or something of their own. Would be nice if it could detect async functions as a context header marker thing, rather than just using the last non-async function... |
Member
Author
|
@kyrias: oh, huh, that's a good point. Probably worth emailing support@github about – do you want to do that? They've been pretty responsive in my experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.