Skip to content

Two small followups to gh-228 #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remleduff merged 2 commits into from
Jun 21, 2017
Merged

Two small followups to gh-228 #232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b36a0
Formatting fixups
njsmith Jun 19, 2017
670dfa9
Test StopIteration can pass through an async_generator async context …
njsmith Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions trio/tests/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ async def manager_issue29692():
assert excinfo.value.args[0] == 'issue29692:Chained'
assert isinstance(excinfo.value.__cause__, ZeroDivisionError)

# This is a little funky because of implementation details in async_generator
# It can all go away once we stop supporting Python3.5
# This is a little funky because of implementation details in
# async_generator It can all go away once we stop supporting Python3.5
with pytest.raises(RuntimeError) as excinfo:
async with manager_issue29692():
exc = StopIteration('issue29692:Unchained')
Expand All @@ -96,6 +96,14 @@ async def manager_issue29692():
assert excinfo.value.args[0] == 'issue29692:Unchained'
assert excinfo.value.__cause__ is None

@acontextmanager
@async_generator
async def noop_async_context_manager():
await yield_()

with pytest.raises(StopIteration):
async with noop_async_context_manager():
raise StopIteration

# Native async generators are only available from Python 3.6 and onwards
nativeasyncgenerators = True
Expand All @@ -112,7 +120,8 @@ async def manager_issue29692_2():
nativeasyncgenerators = False


@pytest.mark.skipif(not nativeasyncgenerators, reason="Python < 3.6 doesn't have native async generators")
@pytest.mark.skipif(not nativeasyncgenerators,
reason="Python < 3.6 doesn't have native async generators")
async def test_native_contextmanager_do_not_unchain_non_stopiteration_exceptions():

with pytest.raises(RuntimeError) as excinfo:
Expand Down