Add typing for _highlevel_open_tcp_listeners.py

[CoolCat467]

This PR adds type annotations to _highlevel_open_tcp_listeners.py.

The only thing that might be a bit off is the type of task_status in the serve_tcp function. I annotated it as trio.lowlevel.Task, but I am not sure this is right.

I would love feedback and any comments on how this could be improved to be more accurate.

[codecov]

Codecov Report

Merging #2724 (2ab89e4) into master (348713a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2724   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         113      113           
  Lines       16669    16683   +14     
  Branches     3021     3025    +4     
=======================================
+ Hits        16487    16501   +14     
  Misses        125      125           
  Partials       57       57           

Files Changed	Coverage Δ
trio/__init__.py	100.00% <ø> (ø)
trio/_dtls.py	96.59% <ø> (ø)
trio/lowlevel.py	100.00% <ø> (ø)
trio/_highlevel_open_tcp_listeners.py	100.00% <100.00%> (ø)
trio/_tests/test_highlevel_open_tcp_listeners.py	98.32% <100.00%> (+0.06%)	⬆️

[A5rocks]

FYI I think verify_types.json is messed up a bit. Maybe your local env is a bit strange?

[TeamSpen210]

A few things that aren't quite right. verify_types.json is a bit picky, it doesn't give the same results for me either.

[jakkdl]

FYI I think verify_types.json is messed up a bit. Maybe your local env is a bit strange?

#2699 tox would help here.
Getting the environment right can actually be quite tricky IME

[jakkdl]

Update pyproject.toml to add this file to the list of files that has increased strictness.

[CoolCat467]

Interesting, Windows pypy 3.9 nightly x64 failed with a segfault from the tests script: https://github.com/python-trio/trio/actions/runs/5705575738/job/15460400267?pr=2724

[jakkdl]

Interesting, Windows pypy 3.9 nightly x64 failed with a segfault from the tests script: https://github.com/python-trio/trio/actions/runs/5705575738/job/15460400267?pr=2724

it does that every now and then in my experience - no clue why. It's always been fixed by rerunning for me, but somebody should maybe open an issue and/or try to investigate the flakiness.

[jakkdl]

Task -> TaskStatus as TeamSpen pointed out, but otherwise mostly good. No need for a re-review from me.

[TeamSpen210]

Looks, good, except for one minor quibble.

[TeamSpen210]

Does this import need to be guarded (due to import cycles), or can it be a real import? It's probably better to just import if we can, so that this can be evaluated at runtime.

[CoolCat467]

Does not need to be guarded as far as I am aware

[CoolCat467]

Reverted in 4a9b024

[jakkdl]

#2687

This is kinda up in the air, I'd love it if we definitively resolved it and added a CI check that made usage consistent and saved review cycles. https://pypi.org/project/flake8-type-checking/

[CoolCat467]

I would suggest using https://pypi.org/project/ruff/ instead, it does the same thing and more but faster and with auto-fix support

[jakkdl]

Given the number of open typing PRs, I'm merging this one. Any minor problems can be addressed later if you want to bother going through it @A5rocks