Typing highlevel open tcp stream#2725
Conversation
Codecov Report
Additional details and impacted files
|
|
This branch includes the commits for #2724 for some reason? |
|
Rats I must have not changed branch before committing |
423c9fe to
cf1f3c7
Compare
jakkdl
left a comment
There was a problem hiding this comment.
Update pyproject.toml to add this file to the list of files that has increased strictness.
…s actually checked despite calling through nursery.start_soon
|
Played around with it locally to figure out what was going on with |
This reverts commit cf546ed.
|
(sorry for the extraneous commits, a13c3cd wasn't showing up for some reason) |
|
Hey @CoolCat467, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂 If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:
If you want to read more, here's the relevant section in our contributing guide. Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you. If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out! |
|
Joining the organization means #2727 is unnecessary and you can contribute to the base PR! |
This PR adds type annotations to
_highlevel_open_tcp_stream.pyI would love feedback and any comments on how this could be improved to be more accurate.