Add types to trio._subprocess#2753
Conversation
It's not public, so it shouldn't be documented
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2753 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 113 113
Lines 16717 16727 +10
Branches 3026 3026
=======================================
+ Hits 16537 16547 +10
Misses 124 124
Partials 56 56
|
|
Missing coverage is an existing issue, |
go ahead and change those if you want, I think
I don't see any reason not to make the |
jakkdl
left a comment
There was a problem hiding this comment.
mostly just a bunch of smallish nits
# Conflicts: # trio/_tests/verify_types.json
Another one of the remaining modules. During typing I did find two type issues:
wait_readable()and similar method should takeint | HasFileno, not justint | socket.subprocess.Popentakesstr | bytes | os.PathLikeor aSequenceof those, butopen_process()does anisinstance(..., str)check so it won't correctly accept those.