Skip to content

Add types to trio._subprocess #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakkdl merged 20 commits into from
Aug 17, 2023
Merged

Add types to trio._subprocess #2753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
105f192
Add type hints to _subprocess
TeamSpen210 Aug 14, 2023
95cf60f
Define overloads for run/open _process, from trio-typing
TeamSpen210 Aug 14, 2023
ffc3eea
Specify default parameters for these overloads
TeamSpen210 Aug 14, 2023
22e5489
Fill in remaining type hints
TeamSpen210 Aug 14, 2023
0c3bff5
Fix a type error - wait_readable() might need different type hints.
TeamSpen210 Aug 14, 2023
0d79bd0
Ignore protocols in coverage
TeamSpen210 Aug 14, 2023
18c7769
Set __qualname__ also
TeamSpen210 Aug 14, 2023
110aae8
Add HasFileno to docs to avoid docs errors
TeamSpen210 Aug 14, 2023
05db494
Suppress __init__ signature for trio.Process
TeamSpen210 Aug 14, 2023
be1843c
Move these declarations into __init__
TeamSpen210 Aug 14, 2023
5902efe
Update verify_types.json
TeamSpen210 Aug 14, 2023
7be3a5f
os.PathLike is not subscriptable in 3.8
TeamSpen210 Aug 14, 2023
2b45d64
Run linters
TeamSpen210 Aug 14, 2023
9624c29
Merge branch 'master' into type-subprocess
TeamSpen210 Aug 14, 2023
bb3484c
Use generic TaskStatus in subprocess
TeamSpen210 Aug 14, 2023
f502d20
Add error codes to type-ignore, then ignore the error code not being …
TeamSpen210 Aug 14, 2023
f8db88b
Add types to trio._subprocess_platform.waitid
TeamSpen210 Aug 15, 2023
cc7f9ad
Make trio._subprocess_platform strict
TeamSpen210 Aug 15, 2023
834ce9e
Fix minor type errors
TeamSpen210 Aug 15, 2023
614297f
Merge remote-tracking branch 'origin/master' into type-subprocess
jakkdl Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/source/reference-io.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,11 @@ task and interact with it while it's running:

.. autofunction:: trio.run_process

.. autoclass:: trio.Process
.. autoclass:: trio._subprocess.HasFileno(Protocol)

.. automethod:: fileno

.. autoclass:: trio.Process()

.. autoattribute:: returncode

Expand Down
5 changes: 5 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ module = [
"trio._highlevel_open_tcp_stream",
"trio._ki",
"trio._socket",
"trio._subprocess",
"trio._subprocess_platform",
"trio._subprocess_platform.kqueue",
"trio._subprocess_platform.waitid",
"trio._subprocess_platform.windows",
"trio._sync",
"trio._threads",
"trio._tools.gen_exports",
Expand Down
Loading