Add type annotations for windows_pipes and its test#2812
Merged
jakkdl merged 13 commits intopython-trio:masterfrom Oct 17, 2023
Merged
Add type annotations for windows_pipes and its test#2812jakkdl merged 13 commits intopython-trio:masterfrom
jakkdl merged 13 commits intopython-trio:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2812 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 115 115
Lines 17230 17230
Branches 3084 3084
=======================================
Hits 17081 17081
Misses 104 104
Partials 45 45
|
Closed
41 tasks
A5rocks
reviewed
Oct 5, 2023
Contributor
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
Looks simple enough, just one small comment
jakkdl
approved these changes
Oct 6, 2023
Member
jakkdl
left a comment
jakkdl
left a comment
There was a problem hiding this comment.
Types on _windows_pipes.py looks trivially correct. The test seems overcomplicated and gives codecov misses, but otherwise perfectly fine as well.
A5rocks
approved these changes
Oct 14, 2023
Contributor
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
nitpicks but overall looks good (I don't really get the = Any bits)
Member
|
agh, why is codecov being so dumb. It's incredibly frustrating that you can't trust the warnings displayed in the |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type annotations for
_windows_pipes.pyand_tests/test_windows_pipes.py.