Add Python 3.11 and 3.12 to Windows and MacOS matrices#3017
Merged
jakkdl merged 5 commits intopython-trio:masterfrom Jun 17, 2024
Merged
Add Python 3.11 and 3.12 to Windows and MacOS matrices#3017jakkdl merged 5 commits intopython-trio:masterfrom
jakkdl merged 5 commits intopython-trio:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3017 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 120 120
Lines 17863 17863
Branches 3217 3217
=======================================
Hits 17798 17798
Misses 46 46
Partials 19 19
|
Contributor
Author
|
Oh, turns out the github branch rename feature doesn't work. Oh well |
Contributor
Author
|
pre-commit.ci autofix |
CoolCat467
approved these changes
Jun 12, 2024
Member
CoolCat467
left a comment
There was a problem hiding this comment.
Looks good to me, simple enough
Member
|
Huh, did we just forget to add these when adding 3.11/3.12 - or was something broken that now works? Not that it matters, good stuff. |
Contributor
Author
|
It looks like I added 3.12 at least and while I can't remember exactly, I'm pretty sure I just forgot to add it to Windows/MacOS (because step 1 was adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #2885