Skip to content

Allow arbitrary overriding of comparision methods #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
z33ky wants to merge 1 commit into from
Closed

Allow arbitrary overriding of comparision methods #2584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,8 +874,10 @@ def check_method_or_accessor_override_for_base(self, defn: FuncBase,
"""Check if method definition is compatible with a base class."""
if base:
name = defn.name()
if name not in ('__init__', '__new__'):
# Check method override (__init__ and __new__ are special).
if name not in ('__init__', '__new__',
'__eq__', '__ne__', '__lt__', '__le__', '__gt__', '__ge__'):
# Check method override (__init__, __new__ and the comparison
# operators are special).
self.check_method_override_for_base_with_name(defn, name, base)
if name in nodes.inplace_operator_methods:
# Figure out the name of the corresponding operator method.
Expand Down