Skip to content

Conversation

@z33ky
Copy link

@z33ky z33ky commented Dec 15, 2016

subclasses should be allowed to override these with differing argument types.

The documentation explicitly allows returning non-bool values for instance.

This also allows typeshed to define comparison methods for object and still error on comparisons of unrelated types (like str() < int()).

@gvanrossum
Copy link
Member

This PR is missing tests for the new functionality. But first I would like to see an issue filed requesting this change -- I would like to see some specific use cases to decide what to do here, and completely excluding the comparisons from compatibility with the base class feels wrong (they are not as unrelated as __init__ or __new__).

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 4, 2017

Agreed that this would benefit from discussion.

@gvanrossum
Copy link
Member

Closing this PR, let's continue the discussion in #2661.

@gvanrossum gvanrossum closed this Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants