Turn mypyc on for ~all substantial code#6851
Merged
Merged
Conversation
JukkaL
approved these changes
May 17, 2019
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
This is a big milestone!
emmatyping
added a commit
that referenced
this pull request
Jun 21, 2019
This fixes an issue with dmypy run not working on Windows introduced in #6851.
JelleZijlstra
pushed a commit
to JelleZijlstra/mypy
that referenced
this pull request
Jun 22, 2019
This fixes an issue with dmypy run not working on Windows introduced in python#6851.
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
With *args support landed (and a few other recent improvements), we can now turn mypyc on for basically everything. This includes: * `BuildManagerBase` goes away and gets merged back into `BuildManager`. `mypyc_hacks.py` is removed * `main.py` can be compiled. (`SplitNamespace` needs to be pulled out because it uses `__getattr__/__setattr__` in ways we don't support yet) * dmypy can be compiled. Unfortunately extension modules can't be run as scripts, so we move `dmypy.py` to `dmypy/client.py` and add an interpreted `dmypy/__main__.py` * A few other minor modules get added in
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
This fixes an issue with dmypy run not working on Windows introduced in python#6851.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With *args support landed (and a few other recent improvements),
we can now turn mypyc on for basically everything.
This includes:
BuildManagerBasegoes away and gets merged back intoBuildManager.mypyc_hacks.pyis removedmain.pycan be compiled. (SplitNamespaceneeds to be pulled out because it uses__getattr__/__setattr__in ways we don't support yet)dmypy.pytodmypy/client.pyand add an interpreteddmypy/__main__.py