Fix MYPYC_BLACKLIST on Windows#7032
Merged
Merged
Conversation
msullivan
approved these changes
Jun 21, 2019
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
Thanks for catching this.
We may need to release a 0.711 with this cherry-picked.
Member
|
It is of course up to @gvanrossum but I would say it makes sense to make a point release. |
Collaborator
|
Yeah a point release seems worth it. |
Member
|
If we do do a point release, can I request that python/typeshed#3077 be included? |
Member
|
Yes, I agree we should also include python/typeshed#3077. (I think this would have to be done by branching typeshed to cherry-pick just that change, and then setting the mypy release branch to use that branch as its submodule. Can this wait until Monday? |
Closed
JelleZijlstra
pushed a commit
to JelleZijlstra/mypy
that referenced
this pull request
Jun 22, 2019
This fixes an issue with dmypy run not working on Windows introduced in python#6851.
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
This fixes an issue with dmypy run not working on Windows introduced in python#6851.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple error has an unfortunately far reaching effect :(
The compiled
__main__.pyfile doesn't work, so dmypy is broken with mypy 0.710 on Windows, which this fixes.Closes #7031