Bump Pillow to 10.0.*#10411
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Primer hit shows a genuine porting need when upgrading the project to Pillow 10. |
AlexWaygood
approved these changes
Jul 6, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM once the other two PRs have gone in
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: imagehash (https://github.com/JohannesBuchner/imagehash)
+ imagehash/__init__.py:42: error: Module has no attribute "ANTIALIAS" [attr-defined]
|
DMRobertson
reviewed
Jul 12, 2023
Comment on lines
-46
to
+42
| MAX_IMAGE_PIXELS: int | None | ||
| USE_CFFI_ACCESS: Incomplete | ||
| MAX_IMAGE_PIXELS: Final[int] |
Contributor
There was a problem hiding this comment.
I'm not sure this is correct. According to https://pillow.readthedocs.io/en/stable/reference/Image.html#PIL.Image.open
This threshold can be changed by setting MAX_IMAGE_PIXELS. It can be disabled by setting Image.MAX_IMAGE_PIXELS = None.
I can't see any mention of this in https://pillow.readthedocs.io/en/stable/releasenotes/10.0.0.html either.
(Noticed in matrix-org/synapse#15898)
This was referenced Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #10409.
Closes: #10394